[Kde-pim] Review Request: Refinement of import/export of kaddressbook from/to GMX

[Urs Joss]

> On 2009-07-08 02:56:08, Allen Winter wrote:
> > Seems fine to me.  You know gmx better than anyone else we have.  Please commit it to both kaddressbook and kcontactmanger in trunk.

Hi Allen

Thanks for your "go". I'd need you or somebody else with svn write access to commit the patch. Would you do that again?

Thanks and kind regards
urs


- Urs


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/941/#review1490
-----------------------------------------------------------


On 2009-07-06 06:45:13, Urs Joss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/941/
> -----------------------------------------------------------
> 
> (Updated 2009-07-06 06:45:13)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The current patch refines the export of addresses from/to GMX. I have asked GMX for documentation on the format of the gmxa file but did not receive documentation. Nevertheless trial and error helped shape an export which is more adequate for my purposes.
> 
> Highlights:
> a) Categories are handled (*)
> b) Export home and work address as before. Instead of the preferred address as a third address, export a mix of other attributes (kind of "Other address"), depending on what's available (arbitrary choice and precedence of items, to be discussed).
> c) The import works again
> d) Better translation of preferred email/phone number into the respective GMX attributes
> e) Export formatted name into nickname - provided there is no assigned nickname in kaddressbook (Nickname is important in the GMX address book)
> f) Import/export prefix instead of title (as title() in kaddressbook refers to the profesional title)
> g) If applicable: The first cell phone is assigned to the home address, the second to the work address and the third to the "other" address. Arbitrary choice.
> h) Add spouse to comment of home address
> 
> I initially did a cleanup of the code (according to the coding style in HACKING), but that made it very difficult to identify the semantic changes in the patch. I'd hand this in once the semantic changes have passed the reviews.
> 
> (*) Please note about categories and GMX:
> 
> The last section of the file format gmxa consists of a category list. Each addressee can be assigned 0, 1 or more categories, stored in a bitfield, which refers to the respective indices in the category list. However, while the bitfield is managed during the import, the category list itself is not actually processed. This means that the user must manually maintain the category list in the GMX UI and make sure the sequence of categories is in line with the category list in the imported file. If he/she does not do that, the addressees will point to wrong (or even non-existing) categories.
> 
> While this is uncomfortable and unelegant, it does work. If a new category had been created and assigned in kaddressbook, the user will need to delete all categories in the GMX UI which are alphabetically sorted beyond the new category. Then a manual insert of the new category and all deleted categories is necessary. This can be done prior to or after the upload of the file with the new categories.
> 
> If and once this patch is finalized (including the code cleanup), it should/could also be applied to kcontactmanager.
> 
> Thanks and kind regards
> Urs
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kaddressbook/xxport/gmx_xxport.cpp 991969 
> 
> Diff: http://reviewboard.kde.org/r/941/diff
> 
> 
> Testing
> -------
> 
> a) exported all addressees of my kaddressbok
> b) reimported the file a) into empty addressbook file and validated the result doing spot checks.
> c) imported file a) into GMX and validated the result doing spot checks
> d) exported the result of c) from GMX into gmxa file and diffed the export from GMX with the file from a)
> e) imported file d) into into empty addressbook file and validated the result dong spot checks.
> 
> It is not possible to conserve everything between those steps (as there is some interpretation between the different formats). E.g. if you don't have a nick name in kaddressbook, you will have the formatted name in the nick name field after export from kaddressbook and reimport of the same file or the file that was loaded into GMX and reexported. In addition the "other" address is assembled from various elements and does not translate perfectly.
> 
> In my eyes the current approach is better than the previous but to some extent arbitrary and far from perfect.
> 
> 
> Thanks,
> 
> Urs
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/