[Kde-pim] Review Request: Use correct quote prefix

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1117/#review1749
-----------------------------------------------------------

Ship it!


Looks, good, please commit.
I didn't test it myself, but I assume it works ok.


/trunk/KDE/kdepim/kmail/kmcomposewin.h
<http://reviewboard.kde.org/r/1117/#comment1139>

    Missing space.
    I always spot those ;)



/trunk/KDE/kdepim/kmail/kmcomposewin.cpp
<http://reviewboard.kde.org/r/1117/#comment1142>

    Minor detail: Instead of hardcoding the template name in two places, I'd like to have one helper function somewhere for that, so the string IDENTITY_%1 is not in two places.
    But that is just a nitpick.



/trunk/KDE/kdepim/kmail/stringutil.h
<http://reviewboard.kde.org/r/1117/#comment1141>

    @param fromAddr should be commented as well, for good measure.


- Thomas


On 2009-07-24 14:55:49, Jonathan Armond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1117/
> -----------------------------------------------------------
> 
> (Updated 2009-07-24 14:55:49)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Respect the quote prefix set in custom identity templates when replying to messages and using 'Add Quote Prefix' in composer.
> 
> 
> This addresses bug 182911.
>     https://bugs.kde.org/show_bug.cgi?id=182911
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/stringutil.h 1001926 
>   /trunk/KDE/kdepim/kmail/stringutil.cpp 1001926 
>   /trunk/KDE/kdepim/kmail/kmcomposewin.h 1001926 
>   /trunk/KDE/kdepim/kmail/kmcomposewin.cpp 1001926 
>   /trunk/KDE/kdepim/kmail/kmmessage.h 1001926 
>   /trunk/KDE/kdepim/kmail/kmmessage.cpp 1001926 
> 
> Diff: http://reviewboard.kde.org/r/1117/diff
> 
> 
> Testing
> -------
> 
> Uses correct quote characters with custom templates, no custom templates and folder identities.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/