[Kde-pim] Review Request: kmail does not pass KIO::HideProgressInfo to the KioJob when opening https:// links

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1008/#review1571
-----------------------------------------------------------

Ship it!


Sounds like a workaround.
Why does this not happen for http links?
I would prefer a fix in kdelibs instead, but I'm also ok with committing a workaround (please use a comment to mark it as such).

- Thomas


On 2009-07-13 10:52:00, Bruno Bigras wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1008/
> -----------------------------------------------------------
> 
> (Updated 2009-07-13 10:52:00)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> When opening "https" links, the kiojob remain open forever.
> 
> this patch force showProgressInfo=false
> http://api.kde.org/4.x-api/kdelibs-apidocs/kio/html/classKRun.html#812a50d5bb5b8e6e830b06ac7508b74b
> 
> Maybe it should be fixed in KRun instead.
> 
> 
> This addresses bug 198671.
>     https://bugs.kde.org/show_bug.cgi?id=198671
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmcommands.cpp 995753 
> 
> Diff: http://reviewboard.kde.org/r/1008/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bruno
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/