[Kde-pim] Review Request: Attempt at fixing server command handling/parsing

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1150/#review1824
-----------------------------------------------------------


Committed the first change and found a similar one for the second problem.

- Kevin


On 2009-07-28 10:09:45, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1150/
> -----------------------------------------------------------
> 
> (Updated 2009-07-28 10:09:45)
> 
> 
> Review request for KDE PIM, Volker Krause and Andras Mantia.
> 
> 
> Summary
> -------
> 
> Following the observed differences in behavior of the server between the version of KDE 4.2 and the current one (see http://lists.kde.org/?l=kde-pim&m=124863374313354&w=2), I tried to find the causes.
> 
> I think I found the one for AKLIST failing in ImapStreamParser::beginList()
> 
> The "Invalid command argument" problem (which can be seen here http://lists.kde.org/?l=kde-pim&m=124873115322776&w=2) seems to come from a premature end in Fetch::parseCommandStream()
> There is probably a better way to fix this then what is in the patch
> 
> 
> Diffs
> -----
> 
>   /trunk/kdesupport/akonadi/server/src/handler/fetch.cpp 1003538 
>   /trunk/kdesupport/akonadi/server/src/imapstreamparser.cpp 1003538 
> 
> Diff: http://reviewboard.kde.org/r/1150/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/