[Kde-pim] Review Request: Implement %SIGNATURE template command.

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/846/#review1524
-----------------------------------------------------------

Ship it!


Looks good, please commit.
Sorry for the review delays.

- Thomas


On 2009-06-15 08:13:03, Jonathan Armond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/846/
> -----------------------------------------------------------
> 
> (Updated 2009-06-15 08:13:03)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Allow customized signature insertion location by implementing %SIGNATURE template command. Resolves ancient feature request 6376, and 159789.
> 
> 
> This addresses bugs 6376 and 159789.
>     https://bugs.kde.org/show_bug.cgi?id=6376
>     https://bugs.kde.org/show_bug.cgi?id=159789
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/templateparser.h 982806 
>   /trunk/KDE/kdepim/kmail/templateparser.cpp 982806 
>   /trunk/KDE/kdepim/kmail/templatesinsertcommand.h 982806 
>   /trunk/KDE/kdepim/kmail/templatesinsertcommand.cpp 982806 
>   /trunk/KDE/kdepim/libkdepim/kmeditor.cpp 982806 
>   /trunk/KDE/kdepimlibs/kpimidentities/signature.h 982945 
>   /trunk/KDE/kdepimlibs/kpimidentities/signature.cpp 982945 
> 
> Diff: http://reviewboard.kde.org/r/846/diff
> 
> 
> Testing
> -------
> 
> Insertion of signature in templates works. HTML does not - templates don't support HTML AFAICT.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/