[Kde-pim] Review Request: Move layout for Accounts page, Receiving tab to .ui file

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1131/#review1817
-----------------------------------------------------------

Ship it!


Looks good, please commit.
See the comments below as well, more stuff could be moved into the UI file.

Thanks for the patch :)


/trunk/KDE/kdepim/kmail/configuredialog.cpp
<http://reviewboard.kde.org/r/1131/#comment1182>

    Coding style: spaces inside parenthesis



/trunk/KDE/kdepim/kmail/configuredialog.cpp
<http://reviewboard.kde.org/r/1131/#comment1184>

    You can already insert this widget in designer, no need to do it manually.
    Even though designer doesn't support KMail's "ListView" class directly, you can add a QTreeWidget in designer, right-click and choose "Promote to", there you can change it into a custom widget.



/trunk/KDE/kdepim/kmail/configuredialog.cpp
<http://reviewboard.kde.org/r/1131/#comment1183>

    Coding style: Remove this trailing space again



/trunk/KDE/kdepim/kmail/configuredialog.cpp
<http://reviewboard.kde.org/r/1131/#comment1185>

    the setEnabled() call here can be moved to the UI file as well.


- Thomas


On 2009-07-27 16:57:30, Torgny Nyblom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1131/
> -----------------------------------------------------------
> 
> (Updated 2009-07-27 16:57:30)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Part of my ongoing struggle to get rid of all hard coded layout.
> 
> Moves the "Accounts Page Receiving Tab" to a .ui file. No other changes, aim is a 1 to 1 port.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/CMakeLists.txt 1003097 
>   /trunk/KDE/kdepim/kmail/configuredialog.cpp 1003097 
>   /trunk/KDE/kdepim/kmail/configuredialog_p.h 1003097 
>   /trunk/KDE/kdepim/kmail/ui/accountspagereceivingtab.ui PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/1131/diff
> 
> 
> Testing
> -------
> 
> Compile, start KMail and inspect the configure dialog.
> 
> 
> Thanks,
> 
> Torgny
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/