[Kde-pim] Review Request: Filter outgoing message before they are sent

[Bruno Bigras]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1045/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

This is the patch from Christian Schaarschmidt with nearly no modification. It add support to filter outgoing message before they are sent.

Should I prevent the user from being able to check "Apply this filter to sent messages" and "Apply this filter before sending messages" at the same time?

I'm not sure what Christian meant with this todo and the note with the commit on the bug report. I was able to add an header for a encrypted email but I'm not sure it didn't screw up something.

kmsender.cpp#504
" // TODO: to support encrypted/signed messages this sould be moved to messagecomposer.cpp
  // Disable the emitting of msgAdded signal, because the message is taken out of the
  // current folder (outbox) and re-added, to make filter actions changing the message
  // work. We don't want that to screw up message counts."

"Note: Quick win. Works for headers and clear text mails."
https://bugs.kde.org/show_bug.cgi?id=48938#c15


This addresses bug 48938.
    https://bugs.kde.org/show_bug.cgi?id=48938


Diffs
-----

  /trunk/KDE/kdepim/kmail/kmfilter.h 998013 
  /trunk/KDE/kdepim/kmail/kmfilter.cpp 998013 
  /trunk/KDE/kdepim/kmail/kmfilterdlg.h 998013 
  /trunk/KDE/kdepim/kmail/kmfilterdlg.cpp 998013 
  /trunk/KDE/kdepim/kmail/kmfiltermgr.h 998013 
  /trunk/KDE/kdepim/kmail/kmfiltermgr.cpp 998013 
  /trunk/KDE/kdepim/kmail/kmsender.cpp 998013 

Diff: http://reviewboard.kde.org/r/1045/diff


Testing
-------

I was able to add an header to email I was sending.


Screenshots
-----------


  http://reviewboard.kde.org/r/1045/s/149/


Thanks,

Bruno

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/