[Kde-pim] Review Request: Filter outgoing message before they are sent

[Thomas McGuire]

> On 2009-07-24 12:53:55, Thomas McGuire wrote:
> > /trunk/KDE/kdepim/kmail/kmfilterdlg.cpp, line 247
> > <http://reviewboard.kde.org/r/1045/diff/1/?file=8604#file8604line247>
> >
> >     Maybe a tooltips for this and the checkbox below would be nice. The tooltips should explain in more details the options, so that the user sees the difference (there was some confusion of the "apply on sent messages" filter in some bug reports, that it didn't filter things _before_ sending)
> >     
> >     Also, the tooltip should explain that not all actions work for the "before sending" filter, like the "add tag" or "mark as read" actions.
> 
>  wrote:
>     I tested the "add tag" with gmail and both with "before sending" and "after sending" it worked but it only tagged to copy in "Local Folders/sent-mail", the copy on gmail was not tagged in both case.

Ah, cool that it works. I was wrong then, sorry.
Note that tags are not synced with IMAP indeed, nobody wrote that yet. But I wouldn't bother to do so for the non-Akonadi based KMail.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1045/#review1735
-----------------------------------------------------------


On 2009-07-24 22:26:41, Bruno Bigras wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1045/
> -----------------------------------------------------------
> 
> (Updated 2009-07-24 22:26:41)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This is the patch from Christian Schaarschmidt with nearly no modification. It add support to filter outgoing message before they are sent.
> 
> Should I prevent the user from being able to check "Apply this filter to sent messages" and "Apply this filter before sending messages" at the same time?
> 
> I'm not sure what Christian meant with this todo and the note with the commit on the bug report. I was able to add an header for a encrypted email but I'm not sure it didn't screw up something.
> 
> kmsender.cpp#504
> " // TODO: to support encrypted/signed messages this sould be moved to messagecomposer.cpp
>   // Disable the emitting of msgAdded signal, because the message is taken out of the
>   // current folder (outbox) and re-added, to make filter actions changing the message
>   // work. We don't want that to screw up message counts."
> 
> "Note: Quick win. Works for headers and clear text mails."
> https://bugs.kde.org/show_bug.cgi?id=48938#c15
> 
> 
> This addresses bug 48938.
>     https://bugs.kde.org/show_bug.cgi?id=48938
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmfilter.h 1001957 
>   /trunk/KDE/kdepim/kmail/kmfilter.cpp 1001957 
>   /trunk/KDE/kdepim/kmail/kmfilterdlg.h 1001957 
>   /trunk/KDE/kdepim/kmail/kmfilterdlg.cpp 1001957 
>   /trunk/KDE/kdepim/kmail/kmfiltermgr.h 1001957 
>   /trunk/KDE/kdepim/kmail/kmfiltermgr.cpp 1001957 
>   /trunk/KDE/kdepim/kmail/kmsender.cpp 1001957 
> 
> Diff: http://reviewboard.kde.org/r/1045/diff
> 
> 
> Testing
> -------
> 
> I was able to add an header to email I was sending.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://reviewboard.kde.org/r/1045/s/149/
> 
> 
> Thanks,
> 
> Bruno
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/