[Kde-pim] Review Request: Move layout for Accounts page, Receiving tab to .ui file

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1131/#review1837
-----------------------------------------------------------

Ship it!


Ok, looks good, please commit.
Extracting classes into own files is almost always a good idea.

Not sure about your subdirectory idea for widgets, most widgets in KMail depend on the rest of KMail.
And moving only a few files there creates inconsitencies in the source, especially if that effort is not finished.
But _the_ argument why I don't like moving code around is that the svn merge tools can't deal with it, so I'd rather avoid it.
Hopefully the situation will be better with git.

- Thomas


On 2009-07-29 11:29:03, Torgny Nyblom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1131/
> -----------------------------------------------------------
> 
> (Updated 2009-07-29 11:29:03)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Part of my ongoing struggle to get rid of all hard coded layout.
> 
> Moves the "Accounts Page Receiving Tab" to a .ui file. No other changes, aim is a 1 to 1 port.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/CMakeLists.txt 1003712 
>   /trunk/KDE/kdepim/kmail/configuredialog.cpp 1003712 
>   /trunk/KDE/kdepim/kmail/configuredialog_p.h 1003712 
>   /trunk/KDE/kdepim/kmail/configuredialog_p.cpp 1003712 
>   /trunk/KDE/kdepim/kmail/configuredialoglistview.h PRE-CREATION 
>   /trunk/KDE/kdepim/kmail/configuredialoglistview.cpp PRE-CREATION 
>   /trunk/KDE/kdepim/kmail/ui/accountspagereceivingtab.ui PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/1131/diff
> 
> 
> Testing
> -------
> 
> Compile, start KMail and inspect the configure dialog.
> 
> 
> Thanks,
> 
> Torgny
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/