[Kde-pim] Review Request: JJ: Unify options to enable or disable the tooltips in the folder and message list

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1105/#review1737
-----------------------------------------------------------


Hi James, thanks very much for the patch! And Welcome!

Looks like that's exactly what we need.
My only concern is that the options page doesn't fit into 800x600 anymore.

Maybe the layout can be rearranged, do you want to have a look at it?
Not sure how to best save space, maybe put the two group boxes about the message structure next to each other? Maybe do the same for the two checkboxes if that is not enough!


/trunk/KDE/kdepim/kmail/configuredialog.cpp
<http://reviewboard.kde.org/r/1105/#comment1129>

    KDEPIM coding style: spaces inside of parenthesis, i.e. change to "QGroupBox( this )"
    Also in other places



/trunk/KDE/kdepim/kmail/configuredialog.cpp
<http://reviewboard.kde.org/r/1105/#comment1128>

    I don't think we need to animate the click here, when just opening/loading the dialog.



/trunk/KDE/kdepim/kmail/kmmainwidget.cpp
<http://reviewboard.kde.org/r/1105/#comment1130>

    What is the reason you removed this here?


- Thomas


On 2009-07-23 19:36:32, James Bendig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1105/
> -----------------------------------------------------------
> 
> (Updated 2009-07-23 19:36:32)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This is a fix to unify Message List and Folder List tooltips so both can be changed in the same places.
> 
> Added "Folder Tooltips" radio group to Configure->Appearance->Layout.
> Added "Display Tooltips" checkbox to Message List header context menu.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/configuredialog.cpp 1001564 
>   /trunk/KDE/kdepim/kmail/configuredialog_p.h 1001564 
>   /trunk/KDE/kdepim/kmail/folderview.cpp 1001564 
>   /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 1001564 
>   /trunk/KDE/kdepim/kmail/messagelistview/core/manager.h 1001564 
>   /trunk/KDE/kdepim/kmail/messagelistview/core/manager.cpp 1001564 
>   /trunk/KDE/kdepim/kmail/messagelistview/core/view.cpp 1001564 
> 
> Diff: http://reviewboard.kde.org/r/1105/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> James
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/