[Kde-pim] Review Request: Combined patch: Null checks on pointers

[Alvaro Manera]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/924/#review1432
-----------------------------------------------------------


As Arthur said on his email, the freeing of null pointers is the least of the "problems". It was a very bad description so I add new info here.

The point of this patch is to fix some security problems found. Like trying to access null strings (eg atoi, before a cmp, etc), that leads to some crashes.

Sorry for that dull description before. ;)

- Alvaro


On 2009-07-02 00:54:01, Alvaro Manera wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/924/
> -----------------------------------------------------------
> 
> (Updated 2009-07-02 00:54:01)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> In this patch I try to fix a few cases where there is no check if the pointer or variables are null.  To avoid such problems as trying to free a null pointer.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/kcal/vcalformat.cpp 990270 
> 
> Diff: http://reviewboard.kde.org/r/924/diff
> 
> 
> Testing
> -------
> 
> Lots of our cases, some of these issues were found running them.
> 
> 
> Thanks,
> 
> Alvaro
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/