[Kde-pim] Review Request: Fix KMail crashy krazy2 issues

[Michael Leupold]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/950/
-----------------------------------------------------------

(Updated 2009-07-08 07:12:27.952680)


Review request for KDE PIM.


Changes
-------

Updated the patch.

@Thomas: I completely agree. While working through the issues I wished for a combination of QPointer and QSharedPointer myself. That seems to be exactly what AutoQPointer is - would be perfect for fixing this very krazy issue.


Summary
-------

This is the start of my work on some of the KMail krazy2 issues fixing the crashy dialog-on-stack issue.

It's not really intended for review as I haven't done any tests yet (it compiles and *might* work). Still I thought it might be a good idea to upload so you know that I'm on it and we can avoid redundant work.

... please ignore the kaddressbook part. I'm not really sure where that comes from and it's definitely not part of the patch :)


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/accountdialog.cpp 992911 
  /trunk/KDE/kdepim/kmail/accountwizard.cpp 992911 
  /trunk/KDE/kdepim/kmail/configuredialog.cpp 992911 
  /trunk/KDE/kdepim/kmail/editorwatcher.cpp 992911 
  /trunk/KDE/kdepim/kmail/favoritefolderview.cpp 992911 
  /trunk/KDE/kdepim/kmail/filterimporterexporter.cpp 992911 
  /trunk/KDE/kdepim/kmail/filterlogdlg.cpp 992911 
  /trunk/KDE/kdepim/kmail/folderdialogacltab.cpp 992911 
  /trunk/KDE/kdepim/kmail/folderrequester.cpp 992911 
  /trunk/KDE/kdepim/kmail/imapaccountbase.cpp 992911 
  /trunk/KDE/kdepim/kmail/kmcommands.cpp 992911 
  /trunk/KDE/kdepim/kmail/kmcomposewin.cpp 992911 
  /trunk/KDE/kdepim/kmail/kmfoldercachedimap.cpp 992911 
  /trunk/KDE/kdepim/kmail/kmlineeditspell.cpp 992911 
  /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 992911 
  /trunk/KDE/kdepim/kmail/messagelistview/core/themeeditor.cpp 992911 
  /trunk/KDE/kdepim/kmail/objecttreeparser.cpp 992911 
  /trunk/KDE/kdepim/kmail/recipientseditor.cpp 992911 
  /trunk/KDE/kdepim/kmail/redirectdialog.cpp 992911 
  /trunk/KDE/kdepim/kmail/snippetwidget.cpp 992911 

Diff: http://reviewboard.kde.org/r/950/diff


Testing
-------


Thanks,

Michael

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/