[Kde-pim] Review Request: Automatically start akonadi when necessary

[Bertjan Broeksema]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1090/#review1691
-----------------------------------------------------------



trunk/KDE/kdepim/kpilot/conduits/akonadibase/akonadisetupwidget.cc
<http://reviewboard.kde.org/r/1090/#comment1097>

    Nit pick: please adhere to coding standards used. i.e. spaces after ( and before ')' etc.



trunk/KDE/kdepim/kpilot/conduits/akonadibase/akonadisetupwidget.cc
<http://reviewboard.kde.org/r/1090/#comment1096>

    Which is already there in line 88, but doesn't seem to work correctly when akonadi is not started and the widget is fired up for the first time.
    
    When akonadi is shut down while the widget is already running it *does* get the nice overlay.


- Bertjan


On 2009-07-20 16:32:40, Robert Marmorstein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1090/
> -----------------------------------------------------------
> 
> (Updated 2009-07-20 16:32:40)
> 
> 
> Review request for KDE PIM, Jason Kasper and Bertjan Broeksema.
> 
> 
> Summary
> -------
> 
> This patch uses Akonadi::Control::start to automatically launch akonadi under the following circumstances:
> 
> 1.  A configuration dialog is launched that needs access to the Akonadi Collection List.
> 
> 2.  The "isOpen" function is called on an akonadi-based conduit.
> 
> This second step means that whenever we sync to an Akonadi conduit, the akonadi server will be started -- or else we abort the sync with an error.
> 
> I have tested this with my LifeDrive and it works for me.  However, I think the "isOpen" solution is a little hacky.  Perhaps a better solution would be to start the server in the loadRecords function.  The problem with this is that "isOpen" will cause the sync to abort before loadRecords is even called.  One possible solution is to move the functionality of isOpen into the loadRecords function and get rid of isOpen calls everywhere.  This is a more invasive procedure, since it would require updating all of the existing akonadi-based conduits to eliminate the "isOpen" check, but I think it is probably the right direction to go, long-term.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kpilot/conduits/akonadibase/akonadidataproxy.cc 999887 
>   trunk/KDE/kdepim/kpilot/conduits/akonadibase/akonadisetupwidget.cc 999887 
> 
> Diff: http://reviewboard.kde.org/r/1090/diff
> 
> 
> Testing
> -------
> 
> Pulled up settings dialog.  Akonadi server was started and I was able to select a collection.  Turned off akonadi server using akonadictl.  The error overlay WAS displayed and the collection dialog was disabled.  Started akonadi server again, overlay disappeared and I was again able to configure a collections.  Then turned off akonadi server and started a sync.  The akonadi server was started and I synced succesfully.
> 
> 
> Thanks,
> 
> Robert
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/