[Kde-pim] Review Request: Fix KMail crashy krazy2 issues

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/950/#review1495
-----------------------------------------------------------


Quite frankly, I don't like using QPointer that much, because it is easy to introduce memory leaks, and it looks like that is what happened in this patch.
The better solution here would be to move AutoQPointer of KAlarm into kdelibs and use that.
Otherwise, the patch is fine.


/trunk/KDE/kdepim/kmail/favoritefolderview.cpp
<http://reviewboard.kde.org/r/950/#comment933>

    missing delete



/trunk/KDE/kdepim/kmail/kmmainwidget.cpp
<http://reviewboard.kde.org/r/950/#comment934>

    missing delete
    



/trunk/KDE/kdepim/kmail/kmmainwidget.cpp
<http://reviewboard.kde.org/r/950/#comment935>

    missing delete?


- Thomas


On 2009-07-08 05:14:27, Michael Leupold wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/950/
> -----------------------------------------------------------
> 
> (Updated 2009-07-08 05:14:27)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This is the start of my work on some of the KMail krazy2 issues fixing the crashy dialog-on-stack issue.
> 
> It's not really intended for review as I haven't done any tests yet (it compiles and *might* work). Still I thought it might be a good idea to upload so you know that I'm on it and we can avoid redundant work.
> 
> ... please ignore the kaddressbook part. I'm not really sure where that comes from and it's definitely not part of the patch :)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/accountdialog.cpp 992911 
>   /trunk/KDE/kdepim/kmail/accountwizard.cpp 992911 
>   /trunk/KDE/kdepim/kmail/configuredialog.cpp 992911 
>   /trunk/KDE/kdepim/kmail/editorwatcher.cpp 992911 
>   /trunk/KDE/kdepim/kmail/favoritefolderview.cpp 992911 
>   /trunk/KDE/kdepim/kmail/filterimporterexporter.cpp 992911 
>   /trunk/KDE/kdepim/kmail/filterlogdlg.cpp 992911 
>   /trunk/KDE/kdepim/kmail/folderdialogacltab.cpp 992911 
>   /trunk/KDE/kdepim/kmail/folderrequester.cpp 992911 
>   /trunk/KDE/kdepim/kmail/imapaccountbase.cpp 992911 
>   /trunk/KDE/kdepim/kmail/kmcommands.cpp 992911 
>   /trunk/KDE/kdepim/kmail/kmcomposewin.cpp 992911 
>   /trunk/KDE/kdepim/kmail/kmfoldercachedimap.cpp 992911 
>   /trunk/KDE/kdepim/kmail/kmlineeditspell.cpp 992911 
>   /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 992911 
>   /trunk/KDE/kdepim/kmail/messagelistview/core/themeeditor.cpp 992911 
>   /trunk/KDE/kdepim/kmail/objecttreeparser.cpp 992911 
>   /trunk/KDE/kdepim/kmail/recipientseditor.cpp 992911 
>   /trunk/KDE/kdepim/kmail/redirectdialog.cpp 992911 
>   /trunk/KDE/kdepim/kmail/snippetwidget.cpp 992911 
> 
> Diff: http://reviewboard.kde.org/r/950/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/