[Kde-pim] Review Request: Use hashes in single file resources

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/931/#review1504
-----------------------------------------------------------

Ship it!


Looks good, commit

- Kevin


On 2009-07-03 05:08:24, Bertjan Broeksema wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/931/
> -----------------------------------------------------------
> 
> (Updated 2009-07-03 05:08:24)
> 
> 
> Review request for KDE PIM, Kevin Krammer and Volker Krause.
> 
> 
> Summary
> -------
> 
> This is a first stab at using hashes to reduce the reloads of SingleFileResource based resources because of changes they wrote themselves to the file. Its also a first step in detecting changes of the files which might influence for example indexes or in the case of mbox the offsets of the deleted items stored in a collection attribute.
> 
> Not covered yet:
> - Change of the hash between two cold starts of the resource.
> - Notifying the implementing classes that the file really has changed and indexes (or whatever) should be updated.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/akonadi/resources/shared/singlefileresource.h 990134 
>   trunk/KDE/kdepim/akonadi/resources/shared/singlefileresourcebase.h 990134 
>   trunk/KDE/kdepim/akonadi/resources/shared/singlefileresourcebase.cpp 990134 
> 
> Diff: http://reviewboard.kde.org/r/931/diff
> 
> 
> Testing
> -------
> 
> Currently I did the following testing with an mbox file:
> 
> 1. touch the mbox file -> result: The resource did not reload the file and no synchronize was triggered.
> 2. add manually (using a text editor) an email to the mbox file and save it -> result: The resource did reload the file and a synchronization was triggered.
> 
> 
> Thanks,
> 
> Bertjan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/