[Kde-pim] Review Request: JJ: Unify options to enable or disable the tooltips in the folder and message list

[James Bendig]

> On 2009-07-24 13:37:08, Thomas McGuire wrote:
> > Hi James, thanks very much for the patch! And Welcome!
> > 
> > Looks like that's exactly what we need.
> > My only concern is that the options page doesn't fit into 800x600 anymore.
> > 
> > Maybe the layout can be rearranged, do you want to have a look at it?
> > Not sure how to best save space, maybe put the two group boxes about the message structure next to each other? Maybe do the same for the two checkboxes if that is not enough!

Hello Thomas,

I was surprised about still fitting the options into 800x600. It makes a lot of sense with the use of virtual machines and VNC sessions though.

I rearranged the layout as you suggested. The message structure groups were put next to each other and the two checkboxes were put next to each other. I also changed the layout style of the folder tooltips group to horizontal. The layout seems to fit under 800x600 now.


> On 2009-07-24 13:37:08, Thomas McGuire wrote:
> > /trunk/KDE/kdepim/kmail/kmmainwidget.cpp, line 574
> > <http://reviewboard.kde.org/r/1105/diff/1/?file=8918#file8918line574>
> >
> >     What is the reason you removed this here?

I removed this writeConfig because it was causing the old configuration state to overwrite changes just made in ConfigureDialog. I would Click "OK" button in ConfigureDialog and then KMMainWidget would try to readConfig(). Immediately inside  KMMainWidget::readConfig() function was this call to KMMainWidget::writeConfig(). That KMMainWidget::writeConfig() would call FolderView::writeConfig(). This would overwrite any changes made by ConfigureDialog before they have a chance to be read and loaded.

I did not notice any further side effects from removing this line. There probably are some I'm failing to find. Why else would a write be called right before a read?


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1105/#review1737
-----------------------------------------------------------


On 2009-07-24 16:27:27, James Bendig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1105/
> -----------------------------------------------------------
> 
> (Updated 2009-07-24 16:27:27)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This is a fix to unify Message List and Folder List tooltips so both can be changed in the same places.
> 
> Added "Folder Tooltips" radio group to Configure->Appearance->Layout.
> Added "Display Tooltips" checkbox to Message List header context menu.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/configuredialog.cpp 1001564 
>   /trunk/KDE/kdepim/kmail/configuredialog_p.h 1001564 
>   /trunk/KDE/kdepim/kmail/folderview.cpp 1001564 
>   /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 1001564 
>   /trunk/KDE/kdepim/kmail/messagelistview/core/manager.h 1001564 
>   /trunk/KDE/kdepim/kmail/messagelistview/core/manager.cpp 1001564 
>   /trunk/KDE/kdepim/kmail/messagelistview/core/view.cpp 1001564 
> 
> Diff: http://reviewboard.kde.org/r/1105/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> James
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/