[Kde-pim] Review Request: KOrganizer: infinite loop of dialogs when merging an ics file
Allen Winter
winter at kde.org
Sun Jul 12 18:45:42 BST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/994/#review1556
-----------------------------------------------------------
trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp
<http://reviewboard.kde.org/r/994/#comment966>
do you mean a KDE5 TODO here?
- Allen
On 2009-07-12 17:11:05, Sergio Martins wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/994/
> -----------------------------------------------------------
>
> (Updated 2009-07-12 17:11:05)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> When we have two active resources and then File->import->merge an ics file, a window popups so you can choose which resource should be used.
>
> The problem is that you will be asked 1 time for each incidence to be imported.
>
> I didn't find a better solution than using a dynamic_cast, all other solutions broke binary compat.
>
> If this patch is OK i'll see if vcalformat needs to be patched too.
>
>
> This addresses bug 199234.
> https://bugs.kde.org/show_bug.cgi?id=199234
>
>
> Diffs
> -----
>
> trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp 994184
> trunk/KDE/kdepimlibs/kcal/calendarresources.h 994184
> trunk/KDE/kdepimlibs/kcal/calendarresources.cpp 994184
>
> Diff: http://reviewboard.kde.org/r/994/diff
>
>
> Testing
> -------
>
> Imported some files
>
>
> Thanks,
>
> Sergio
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list