[Kde-pim] Review Request: Libical can return a null version

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/923/#review1441
-----------------------------------------------------------

Ship it!


Looks fine.  I'll commit this.  You can close this as submitted.

- Allen


On 2009-07-02 00:38:52, Alvaro Manera wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/923/
> -----------------------------------------------------------
> 
> (Updated 2009-07-02 00:38:52)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> In some cases even if it is checked before if icalcomponent_get_first_property is not null, icalproperty_get_version does return a null. In order to fix those hence another check.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp 990270 
> 
> Diff: http://reviewboard.kde.org/r/923/diff
> 
> 
> Testing
> -------
> 
> Lots of test cases as always.
> 
> 
> Thanks,
> 
> Alvaro
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/