[Kde-pim] Review Request: Add internationalisation dbus interfaces for akonadi server

[Volker Krause]

> On 2009-07-17 08:17:29, Kevin Krammer wrote:
> > Since we are currently the only client implementation we could just change the signature of the getter methods to the two string variant, e.g.
> > agentName(string:identifier) -> agentName(string:identifier, string:language)
> > 
> > language empty being the current behavior
> 
> Volker Krause wrote:
>     I was thinking about dropping the language parameter altogether and return the translated name by default. Or are there use-cases for retrieving the untranslated name or a name in a different language?
> 
> Tom Albers wrote:
>     How does that work? I mean, you need to pass the language to the server somehow, right?

If this is indeed necessary then this would not work of course. But isn't the language set in some environment variable which the server can read?


- Volker


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1033/#review1640
-----------------------------------------------------------


On 2009-07-16 19:18:13, Tom Albers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1033/
> -----------------------------------------------------------
> 
> (Updated 2009-07-16 19:18:13)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> At this moment the 'Add resource' dialog is not translated. This is because the server always returns the english values. This patch parses the complete desktop files (improvements welcome) and provides dbus interfaces to get to the values.
> 
> 
> Diffs
> -----
> 
>   /trunk/kdesupport/akonadi/server/control/agenttype.cpp 995410 
>   /trunk/kdesupport/akonadi/server/control/agenttype.h 995410 
>   /trunk/kdesupport/akonadi/server/control/agentmanager.cpp 995410 
>   /trunk/kdesupport/akonadi/server/control/agentmanager.h 995410 
>   /trunk/kdesupport/akonadi/interfaces/org.freedesktop.Akonadi.AgentManager.xml 995410 
> 
> Diff: http://reviewboard.kde.org/r/1033/diff
> 
> 
> Testing
> -------
> 
> $ qdbus org.freedesktop.Akonadi.Control /AgentManager org.freedesktop.Akonadi.AgentManager.agentNameI18n nl akonadi_nntp_resource
> Usenet-nieuwsgroepen (NNTP)
> $ qdbus org.freedesktop.Akonadi.Control /AgentManager org.freedesktop.Akonadi.AgentManager.agentName akonadi_nntp_resource
> Usenet Newsgroups (NNTP)
> 
> 
> Thanks,
> 
> Tom
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/