[Kde-pim] Review Request: Fix KMail crashy krazy2 issues

[Bertjan Broeksema]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/950/#review1487
-----------------------------------------------------------



/trunk/KDE/kdepim/kaddressbook/views/contactlistview.cpp
<http://reviewboard.kde.org/r/950/#comment921>

    Why did you remove this check?



/trunk/KDE/kdepim/kmail/messagelistview/core/themeeditor.cpp
<http://reviewboard.kde.org/r/950/#comment922>

    The dialog doesn't get deleted here?



/trunk/KDE/kdepim/kmail/messagelistview/core/themeeditor.cpp
<http://reviewboard.kde.org/r/950/#comment923>

    And here neither.


- Bertjan


On 2009-07-07 16:49:42, Michael Leupold wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/950/
> -----------------------------------------------------------
> 
> (Updated 2009-07-07 16:49:42)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This is the start of my work on some of the KMail krazy2 issues fixing the crashy dialog-on-stack issue.
> 
> It's not really intended for review as I haven't done any tests yet (it compiles and *might* work). Still I thought it might be a good idea to upload so you know that I'm on it and we can avoid redundant work.
> 
> ... please ignore the kaddressbook part. I'm not really sure where that comes from and it's definitely not part of the patch :)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmfoldercachedimap.cpp 992417 
>   /trunk/KDE/kdepim/kmail/folderrequester.cpp 992417 
>   /trunk/KDE/kdepim/kmail/imapaccountbase.cpp 992417 
>   /trunk/KDE/kdepim/kmail/kmcommands.cpp 992417 
>   /trunk/KDE/kdepim/kmail/kmcomposewin.cpp 992417 
>   /trunk/KDE/kdepim/kmail/folderdialogacltab.cpp 992417 
>   /trunk/KDE/kdepim/kmail/accountwizard.cpp 992417 
>   /trunk/KDE/kdepim/kmail/configuredialog.cpp 992417 
>   /trunk/KDE/kdepim/kmail/editorwatcher.cpp 992417 
>   /trunk/KDE/kdepim/kmail/favoritefolderview.cpp 992417 
>   /trunk/KDE/kdepim/kaddressbook/views/contactlistview.cpp 992417 
>   /trunk/KDE/kdepim/kmail/accountdialog.cpp 992417 
>   /trunk/KDE/kdepim/kmail/filterimporterexporter.cpp 992417 
>   /trunk/KDE/kdepim/kmail/filterlogdlg.cpp 992417 
>   /trunk/KDE/kdepim/kmail/kmlineeditspell.cpp 992417 
>   /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 992417 
>   /trunk/KDE/kdepim/kmail/messagelistview/core/themeeditor.cpp 992417 
>   /trunk/KDE/kdepim/kmail/objecttreeparser.cpp 992417 
>   /trunk/KDE/kdepim/kmail/recipientseditor.cpp 992417 
>   /trunk/KDE/kdepim/kmail/redirectdialog.cpp 992417 
>   /trunk/KDE/kdepim/kmail/snippetwidget.cpp 992417 
> 
> Diff: http://reviewboard.kde.org/r/950/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/