[Kde-pim] Review Request: Apply template when switching identity in message composer

[Thomas McGuire]

> On 2009-07-10 10:23:29, Thomas McGuire wrote:
> > There still seem to be bugs:
> > - When I reply with a custom template and the default identity is an identity that has a signature enabled, the text in the composer does not come from the custom template, but from some other (non-default) identity. When I switch identities, this then changes to the correct custom template, even if I switch back to the default identity.
> > - A very similar thing happens when replying by selecting some text and hitting 'r': The text in the composer is the full text, not the selected text. Again, this works when changing the identity.
> > 
> > Sorry for the late review, I should really have done this earlier.
> 
> Jonathan Armond wrote:
>     Hmm, I can't reproduce these bugs. Are you sure you used diff r4? Perhaps you could describe you identity list? i.e. which ones have custom templates, signatures, what global templates and global custom templates.

Here is how to reproduce this with a clean config. I guess some of those steps are not needed, but this at least reliably triggers the bug.
I'm using the lastest diff, yes.

You need two identities, A and B.
Both should have plain signatures enabled, with the text "A's sig" and "B's sig".
Both identities should have per-identity custom templates enabled. Append "A's Reply To Sender Template" to the reply to sender template of A, and do
the same with B.
A should be the default identity.
Then, create a custom reply template in the Composer settings, named "Test" with the text "%QUOTE custom reply template".
Afterwards, go to the folder properties of your draft folder and uncheck "Use default identity". Choose "B" as identity of the drafts folder.
Now, create some dummy message with "Dummy message" (and no sig) as text and save it as a draft.
The last step: Reply to that draft message with the custom template.

Expectation: Since I explicitly replied with a custom template, I expect the custom template to be used. Instead I see B's reply template.
If I click the B identity in the identity combobox again, I see the correct custom template.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/833/#review1529
-----------------------------------------------------------


On 2009-06-18 03:28:33, Jonathan Armond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/833/
> -----------------------------------------------------------
> 
> (Updated 2009-06-18 03:28:33)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Apply new template when switching identity in the message composer, as long the message has not been modified. NB: changing identity no longer marks message as modified.
> 
> Apply template to Forward As Attachment messages.
> 
> First attempt at fixing bug 143199.
> 
> 
> This addresses bugs 143199, 179754 and 186843.
>     https://bugs.kde.org/show_bug.cgi?id=143199
>     https://bugs.kde.org/show_bug.cgi?id=179754
>     https://bugs.kde.org/show_bug.cgi?id=186843
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/composer.h 983328 
>   /trunk/KDE/kdepim/kmail/kmcommands.cpp 983328 
>   /trunk/KDE/kdepim/kmail/kmcomposewin.h 983328 
>   /trunk/KDE/kdepim/kmail/kmcomposewin.cpp 983328 
>   /trunk/KDE/kdepim/kmail/kmkernel.cpp 983328 
>   /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 983328 
>   /trunk/KDE/kdepim/kmail/templateparser.h 983328 
>   /trunk/KDE/kdepim/kmail/templateparser.cpp 983328 
> 
> Diff: http://reviewboard.kde.org/r/833/diff
> 
> 
> Testing
> -------
> 
> Template properly parsed for new, reply, reply all and forward. Switches between custom, global and no templates properly. Doesn't switch after modifying message.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/