[Kde-pim] Review Request: Aviod generating recurrent events until everything crashes.

[Allen Winter]

> On 2009-07-01 05:36:53, Allen Winter wrote:
> > very good idea.

oh, you don't have commit access iirc.

i'll commit for you.  but I plan to use n = qMin(n, LOOP_LIMIT).

please close this review as submitted.


- Allen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/917/#review1429
-----------------------------------------------------------


On 2009-07-01 05:22:49, Alvaro wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/917/
> -----------------------------------------------------------
> 
> (Updated 2009-07-01 05:22:49)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> If there is a recurrence very often and for a very long time, the recurrence list it is so long the the QList overflows and crashes. Hence here I propose to use the already available LOOP_LIMIT to avoind "exploding" so many instances of a recurrence and crash everything.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/kcal/recurrencerule.cpp 976970 
> 
> Diff: http://reviewboard.kde.org/r/917/diff
> 
> 
> Testing
> -------
> 
> I have run the patch to all my test cases and it works ;) Not a big change.
> 
> 
> Thanks,
> 
> Alvaro
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/