[Kde-pim] Review Request: Apply template when switching identity in message composer

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/833/#review1529
-----------------------------------------------------------


There still seem to be bugs:
- When I reply with a custom template and the default identity is an identity that has a signature enabled, the text in the composer does not come from the custom template, but from some other (non-default) identity. When I switch identities, this then changes to the correct custom template, even if I switch back to the default identity.
- A very similar thing happens when replying by selecting some text and hitting 'r': The text in the composer is the full text, not the selected text. Again, this works when changing the identity.

Sorry for the late review, I should really have done this earlier.

- Thomas


On 2009-06-18 03:28:33, Jonathan Armond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/833/
> -----------------------------------------------------------
> 
> (Updated 2009-06-18 03:28:33)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Apply new template when switching identity in the message composer, as long the message has not been modified. NB: changing identity no longer marks message as modified.
> 
> Apply template to Forward As Attachment messages.
> 
> First attempt at fixing bug 143199.
> 
> 
> This addresses bugs 143199, 179754 and 186843.
>     https://bugs.kde.org/show_bug.cgi?id=143199
>     https://bugs.kde.org/show_bug.cgi?id=179754
>     https://bugs.kde.org/show_bug.cgi?id=186843
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/composer.h 983328 
>   /trunk/KDE/kdepim/kmail/kmcommands.cpp 983328 
>   /trunk/KDE/kdepim/kmail/kmcomposewin.h 983328 
>   /trunk/KDE/kdepim/kmail/kmcomposewin.cpp 983328 
>   /trunk/KDE/kdepim/kmail/kmkernel.cpp 983328 
>   /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 983328 
>   /trunk/KDE/kdepim/kmail/templateparser.h 983328 
>   /trunk/KDE/kdepim/kmail/templateparser.cpp 983328 
> 
> Diff: http://reviewboard.kde.org/r/833/diff
> 
> 
> Testing
> -------
> 
> Template properly parsed for new, reply, reply all and forward. Switches between custom, global and no templates properly. Doesn't switch after modifying message.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/