[Kde-pim] Review Request: Refresh IMAP cache even enabled when action can't be used

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/958/#review1527
-----------------------------------------------------------


Looks good, but needs a little improvement: It gets the action by name, by querying the action collection for "file_invalidate_imap_cache". If the action is renamed, we have a bug which the compiler will not find.
A better solution would be to store the action as a member variable in setupActions() and use that member variable later. Can you make this change?

- Thomas


On 2009-07-08 17:37:41, Bruno Bigras wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/958/
> -----------------------------------------------------------
> 
> (Updated 2009-07-08 17:37:41)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> "The Refresh IMAP Cache action in the File menu is even enabled when there are no IMAP accounts or when no IMAP folder is currently selected. Your job is to fix this be disabling the action when necessary."
> http://techbase.kde.org/Projects/PIM/KMail_Junior_Jobs#Bug_71945:_Refresh_IMAP_cache_even_enabled_when_action_can.27t_be_used
> 
> It seem that when the "Refresh Local IMAP Cache" button is used, it work for every "Disconnected IMAP" account at the same time so I think it's not needed to activate/deactivate the action based on the account selected.
> 
> 
> This addresses bug 71945.
>     https://bugs.kde.org/show_bug.cgi?id=71945
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 993591 
> 
> Diff: http://reviewboard.kde.org/r/958/diff
> 
> 
> Testing
> -------
> 
> It works when KMail start and also if a "Disconnected IMAP" account is added or removed.
> 
> 
> Thanks,
> 
> Bruno
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/