[Kde-pim] Review Request: IMAP Akonadi Resource: custom expunge interface

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/938/#review1494
-----------------------------------------------------------


A few adjustments are still needed. But we're close to a proper solution for this.


/trunk/KDE/kdepim/akonadi/resources/imap/imapresource.h
<http://reviewboard.kde.org/r/938/#comment928>

    Please rename customPurge() to automaticPurgeEnabled(). Means you'll have to revert the logic of course.



/trunk/KDE/kdepim/akonadi/resources/imap/imapresource.h
<http://reviewboard.kde.org/r/938/#comment927>

    This one shouldn't be virtual.



/trunk/KDE/kdepim/akonadi/resources/imap/imapresource.h
<http://reviewboard.kde.org/r/938/#comment929>

    Please rename to m_automaticPurgeEnabled.



/trunk/KDE/kdepim/akonadi/resources/imap/imapresource.cpp
<http://reviewboard.kde.org/r/938/#comment932>

    Because of my other comments the logic will probably be reversed here.



/trunk/KDE/kdepim/akonadi/resources/imap/imapresource.cpp
<http://reviewboard.kde.org/r/938/#comment930>

    This class is missing from the patch but I suspect it's trivial. ;-)



/trunk/KDE/kdepim/akonadi/resources/imap/imapresource.cpp
<http://reviewboard.kde.org/r/938/#comment931>

    Because of my previous comments the logic will probably be reversed here.


- Kevin


On 2009-07-04 07:27:10, Tom Albers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/938/
> -----------------------------------------------------------
> 
> (Updated 2009-07-04 07:27:10)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This patch adds three public methods which are made available through DBus. This way Mailody can maintain it's implementation where deleted messages are marked for deletion and expunge only happens when explicitely asked.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/akonadi/resources/imap/imapresource.h 987929 
>   /trunk/KDE/kdepim/akonadi/resources/imap/imapresource.cpp 987929 
> 
> Diff: http://reviewboard.kde.org/r/938/diff
> 
> 
> Testing
> -------
> 
> Mailody.
> 
> 
> Thanks,
> 
> Tom
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/