[Kde-pim] Review Request: Move layout for Accounts page, Receiving tab to .ui file

[Torgny Nyblom]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1131/
-----------------------------------------------------------

(Updated 2009-07-29 11:29:03.772452)


Review request for KDE PIM.


Changes
-------

To solve the issue with ListView, I had to extract that class from configuredialog_p.* to configuredialoglistview.*. This was (I think) due to the fact that the .ui generated .h file referenced the _p.h file and that in turn included the .ui generated .h file. I was unable to solve this by forward declaring the Ui_ class in the _p.h file.

Is this an ok solution?
Preferable the ListView files should go into a "uicontrols" subfolder together with all other controls. If so should this be a "move one when changing it" or "all in one go" move?


Summary
-------

Part of my ongoing struggle to get rid of all hard coded layout.

Moves the "Accounts Page Receiving Tab" to a .ui file. No other changes, aim is a 1 to 1 port.


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/CMakeLists.txt 1003712 
  /trunk/KDE/kdepim/kmail/configuredialog.cpp 1003712 
  /trunk/KDE/kdepim/kmail/configuredialog_p.h 1003712 
  /trunk/KDE/kdepim/kmail/configuredialog_p.cpp 1003712 
  /trunk/KDE/kdepim/kmail/configuredialoglistview.h PRE-CREATION 
  /trunk/KDE/kdepim/kmail/configuredialoglistview.cpp PRE-CREATION 
  /trunk/KDE/kdepim/kmail/ui/accountspagereceivingtab.ui PRE-CREATION 

Diff: http://reviewboard.kde.org/r/1131/diff


Testing
-------

Compile, start KMail and inspect the configure dialog.


Thanks,

Torgny

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/