[Kde-pim] Review Request: Akonadi ICal Resource: use same MIME type for notes everywhere

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/68/#review103
-----------------------------------------------------------

Ship it!


Good catch!

- Volker


On 2009-02-13 17:14:59, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/68/
> -----------------------------------------------------------
> 
> (Updated 2009-02-13 17:14:59)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> While checking MIME type usage, I found that icalresource.cpp was using two different MIME types (vnd.akonadi.note (singular) twice, vnd.akonadi.notes (plural) once.
> 
> Patch makes it using a constant instead. Since the .desktop file also contains the plural form, I chose that one, assuming that the two times singular form happened through copy&paste.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/akonadi/resources/ical/icalresource.h 925462 
>   /trunk/KDE/kdepim/akonadi/resources/ical/icalresource.cpp 925462 
> 
> Diff: http://reviewboard.kde.org/r/68/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/