[Kde-pim] Review Request: Refactor the formatting functions inside KCal

Sergio Martins iamsergio at gmail.com
Fri Feb 20 19:38:08 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/134/#review204
-----------------------------------------------------------


KLocal's formatDate(const KLocale *locale, const QDateTime &dateTime, KLocale::DateFormat, bool includeSeconds, int daysToNow); 4th parameter, if true, will include seconds in the string representation, so you have to pass !shortfmt and not shortfmt.

This was fixed a few days ago in todo.cpp, event.cpp and incidencebase.cpp

- Sergio


On 2009-02-20 05:16:09, Csaba Kertész wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/134/
> -----------------------------------------------------------
> 
> (Updated 2009-02-20 05:16:09)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Move the rest formatting functions to incidenceformatter class inside KCal
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/kcal/htmlexport.cpp 924164 
>   trunk/KDE/kdepimlibs/kcal/incidenceformatter.h 924164 
>   trunk/KDE/kdepimlibs/kcal/incidenceformatter.cpp 924164 
> 
> Diff: http://reviewboard.kde.org/r/134/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Csaba
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list