[Kde-pim] Review Request: Use EntityDisplayAttribute::displayName() instead of Collection::name() when available

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/45/#review50
-----------------------------------------------------------

Ship it!


Looks good as well.

- Volker


On 2009-02-08 09:16:17, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/45/
> -----------------------------------------------------------
> 
> (Updated 2009-02-08 09:16:17)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The client side bridges currently use Collection::name() as the respective sub resource labels. However this field is usually just the resource identifier, e.g. akonadi_ical_resource_0
> 
> This makes them use the display attribute if one is available, basically the same thing the CollectionModel would do for DisplayRole.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kresources/akonadi/kcal/resourceakonadi.cpp 923340 
>   /trunk/KDE/kdepim/kresources/akonadi/kabc/resourceakonadi.cpp 923340 
> 
> Diff: http://reviewboard.kde.org/r/45/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/