[Kde-pim] Review Request: Improvement of QtConcurrent patch for client bridges
Kevin Krammer
kevin.krammer at gmx.at
Thu Feb 5 00:44:56 GMT 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/25/
-----------------------------------------------------------
(Updated 2009-02-04 16:44:56.425620)
Review request for KDE PIM.
Changes
-------
fixed diff base path
Summary
-------
Thinking about Thomas' comment about possible causes for the "application does not complete quit" issue, I remembered that Akonadi jobs do a deleteLater() thing and the worker thread's event loop might not have a chance to run after the worker methods return.
So I am now using a dreaded :) nested event loop in the thread context to wait for the job's destroyed() signal.
Seems to work.
Diffs (updated)
-----
/trunk/KDE/kdepim/kresources/akonadi/kabc/resourceakonadi.cpp 921044
Diff: http://reviewboard.kde.org/r/25/diff
Testing
-------
Thanks,
Kevin
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list