[Kde-pim] Review Request: Send payload file name to the client [server side]

[Volker Krause]

> On 2009-02-12 01:42:27, Volker Krause wrote:
> > I don't see where the actual filename is sent (might be just me being blind though). Also, we probably should increment the protocol version number in akonadiconnection.cpp.
> 
> Andras Mantia wrote:
>     fetch.cpp, lines 249-251 in the diff. data holds the file name if the payload is in a file. If external data loading is not supported in the client and the data is in a file, the server itself translated the data, otherwise it just sends what was there, in that case the file name.

I see, so that was indeed just me being blind. Feel free to commit then.


- Volker


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/54/#review64
-----------------------------------------------------------


On 2009-02-11 13:20:53, Andras Mantia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/54/
> -----------------------------------------------------------
> 
> (Updated 2009-02-11 13:20:53)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This patch extends the client/server protocol in a way that if the client supports direct loading of the payload data from a file, the filename is sent through the socket, not the whole data, thus limiting the amount of data that needs to be transported. This is the server side of the patch.
> 
> 
> Diffs
> -----
> 
>   trunk/kdesupport/akonadi/libs/protocol_p.h 924623 
>   trunk/kdesupport/akonadi/server/src/handler/fetch.h 924623 
>   trunk/kdesupport/akonadi/server/src/handler/fetch.cpp 924623 
> 
> Diff: http://reviewboard.kde.org/r/54/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andras
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/