[Kde-pim] Review Request: Potential fix for the nested event loop problems caused the the Akonadi client bridge

Volker Krause vkrause at kde.org
Tue Feb 3 14:49:36 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4/#review1
-----------------------------------------------------------

Ship it!


Looks good to me.

- Volker


On 2009-02-03 06:21:29, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4/
> -----------------------------------------------------------
> 
> (Updated 2009-02-03 06:21:29)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Since synchronous processing using KJob::exec() leads to all kind of strange behavior, this is an attempt to do the job in a thread and block the caller using QtConcurrent.
> Only implements the parts for loading so far.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kresources/akonadi/kabc/resourceakonadi.cpp 920463 
> 
> Diff: http://reviewboard.kde.org/r/4/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list