[Kde-pim] Review Request: Warn if a mail is sent to too many recipients

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/133/#review195
-----------------------------------------------------------

Ship it!


Seems fine, except the comments below. Commit after changing that.
I admit I didn't test this patch yet :)


branches/kdepim/enterprise/kdepim/kmail/kmcomposewin.h
<http://reviewboard.kde.org/r/133/#comment105>

    That method should be const.



branches/kdepim/enterprise/kdepim/kmail/kmcomposewin.cpp
<http://reviewboard.kde.org/r/133/#comment106>

    Can checkExternalEditorFinished and checkRecipientNumber be factored out in a convenience helper method to avoid duplicate code?



branches/kdepim/enterprise/kdepim/kmail/kmcomposewin.cpp
<http://reviewboard.kde.org/r/133/#comment108>

    2 spaces indentation please, not 4.



branches/kdepim/enterprise/kdepim/kmail/kmcomposewin.cpp
<http://reviewboard.kde.org/r/133/#comment109>

    The diff looks red here at this point...


- Thomas


On 2009-02-20 04:57:56, Andras Mantia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/133/
> -----------------------------------------------------------
> 
> (Updated 2009-02-20 04:57:56)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Implement https://www.intevation.de/roundup/kolab/issue3377 , add a warning if there are too many recipients. The warning can be turned off and the threshold number is user configurable.
> 
> 
> Diffs
> -----
> 
>   branches/kdepim/enterprise/kdepim/kmail/configuredialog.cpp 928827 
>   branches/kdepim/enterprise/kdepim/kmail/configuredialog_p.h 928827 
>   branches/kdepim/enterprise/kdepim/kmail/kmail.kcfg 928827 
>   branches/kdepim/enterprise/kdepim/kmail/kmcomposewin.h 928827 
>   branches/kdepim/enterprise/kdepim/kmail/kmcomposewin.cpp 928827 
> 
> Diff: http://reviewboard.kde.org/r/133/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andras
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/