[Kde-pim] Review Request: Support for the metadata-over-DBus API in Kmail

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/168/#review272
-----------------------------------------------------------



/trunk/KDE/kdepim/kmail/kmkernel.cpp
<http://reviewboard.kde.org/r/168/#comment149>

    Is this instance deleted somewhere?



/trunk/KDE/kdepim/kmail/mailmanagerimpl.h
<http://reviewboard.kde.org/r/168/#comment150>

    the non-POD arguments should be passed as const reference, e.g.
    const QStringList &subjects
    
    The const pointer is OK



/trunk/KDE/kdepim/kmail/mailmanagerimpl.cpp
<http://reviewboard.kde.org/r/168/#comment151>

    Wouldn't it be easier to let the QDBus code generator also generate an QDBusInterface subclass for this?



/trunk/KDE/kdepim/kmail/mailmanagerimpl.cpp
<http://reviewboard.kde.org/r/168/#comment152>

    Ok, this is mainly a personal style preference, but I would do
    
    for ( ; i < fcount; ++i ) {
      if ( processed >= max_per_dbus_call )
        break;
    }
    
    Indicate what the main processing condition is and under which circumstances the loop will be left earlier than that



/trunk/KDE/kdepim/kmail/mailmanagerimpl.cpp
<http://reviewboard.kde.org/r/168/#comment153>

    Personal preference again:
    if ( !subjects.isEmpty() )



/trunk/KDE/kdepim/libkdepim/CMakeLists.txt
<http://reviewboard.kde.org/r/168/#comment154>

    It might be sufficient to move the file to the kmail source directory.
    
    It will probably not be implemented by any other application in the kdepim module and probably also not used.
    


- Kevin


On 2009-02-25 06:10:18, Philip Van Hoof wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/168/
> -----------------------------------------------------------
> 
> (Updated 2009-02-25 06:10:18)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Support for the metadata-over-DBus API in Kmail.
> 
> https://bugs.kde.org/show_bug.cgi?id=185331
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=185331.
>     https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=185331
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/CMakeLists.txt 917233 
>   /trunk/KDE/kdepim/kmail/kmkernel.h 917233 
>   /trunk/KDE/kdepim/kmail/kmkernel.cpp 917233 
>   /trunk/KDE/kdepim/kmail/mailmanagerimpl.h PRE-CREATION 
>   /trunk/KDE/kdepim/kmail/mailmanagerimpl.cpp PRE-CREATION 
>   /trunk/KDE/kdepim/libkdepim/CMakeLists.txt 917233 
>   /trunk/KDE/kdepim/libkdepim/interfaces/org.freedesktop.email.metadata.Manager.xml PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/168/diff
> 
> 
> Testing
> -------
> 
> Tested with this test tool:
> http://live.gnome.org/Evolution/Metadata?action=AttachFile&do=view&target=valaclientsample.vala
> 
> 
> Thanks,
> 
> Philip
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/