[Kde-pim] Review Request: New dialog in KOrganizer to choose whether to dissociate future incidences or only the current one

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/193/#review281
-----------------------------------------------------------

Ship it!


Looks really good.  I might want to play with the wording of the dialog questions a bit later, but I can't think of anything better at the moment.

- Allen


On 2009-02-26 08:16:12, Sergio Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/193/
> -----------------------------------------------------------
> 
> (Updated 2009-02-26 08:16:12)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> With this patch, when right clicking on a recurring incidence, and choosing "Dissociate From Recurrence" one of two dialogues will come up.
> 
> If the occurrence isn't the first one, dialog 2 appears, in which the user can choose to dissociate only the selected occurrence or also the future ones.
> 
> If the occurrence is the first one, dialog 1 appears, dissociation of current+future doesn't make sense in this case because there aren't any previous incidences.
> 
> For those who don't know what dissociation means:
> 
> Imagine you have a weekly event, with occurrences O1, O2, O3, O4, O5 ...On, if you select O3 and dissociate it you will end up with 2 events, one at O3's date, and a recurring one on O1, O2, O4, O5, On.
> 
> If you selected O3 and "Also Dissociate Future", you would end up with 2 events, a recurring one at O1, O2, O3, and one at O3, O4, O5 ..On
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/korganizer/interfaces/korganizer/baseview.h 932360 
>   trunk/KDE/kdepim/korganizer/koeventpopupmenu.h 932360 
>   trunk/KDE/kdepim/korganizer/koeventpopupmenu.cpp 932360 
>   trunk/KDE/kdepim/korganizer/koeventview.cpp 932360 
>   trunk/KDE/kdepim/korganizer/koviewmanager.cpp 932360 
>   trunk/KDE/kdepim/korganizer/calendarview.cpp 932360 
>   trunk/KDE/kdepim/korganizer/calendarview.h 932360 
> 
> Diff: http://reviewboard.kde.org/r/193/diff
> 
> 
> Testing
> -------
> 
> Dissociate the first occurrence and choose "Yes".
> Dissociate the first occurrence and choose "No".
> Dissociate a middle occurrence and choose "Only Dissociate This One".
> Dissociate a middle occurrence and choose "Also Dissociate Future Ones".
> Try to dissociate a recurrence which is last and first.
> 
> 
> Screenshots
> -----------
> 
> Dialog 1
>   http://reviewboard.kde.org/r/193/s/35/
> Dialog 2
>   http://reviewboard.kde.org/r/193/s/36/
> 
> 
> Thanks,
> 
> Sergio
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/