[Kde-pim] Review Request: Store payload data in files

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/13/#review7
-----------------------------------------------------------



trunk/kdesupport/akonadi/server/src/handler/store.cpp
<http://reviewboard.kde.org/r/13/#comment3>

    That loops looks very strange, it totally ignores the given item and just checks if a part with the given name exists anywhere in the db. Of course this is unrelated to your changes.



trunk/kdesupport/akonadi/server/src/storage/parthelper.h
<http://reviewboard.kde.org/r/13/#comment5>

    the only usage of this one looks wrong (unrelated to your changes)



trunk/kdesupport/akonadi/server/src/storage/parthelper.h
<http://reviewboard.kde.org/r/13/#comment2>

    is that actually used anywhere?



trunk/kdesupport/akonadi/server/src/storage/parthelper.h
<http://reviewboard.kde.org/r/13/#comment4>

    seems unused as well



trunk/kdesupport/akonadi/server/src/storage/parthelper.cpp
<http://reviewboard.kde.org/r/13/#comment10>

    Good enough for now, but I think we want something more elaborate here in the long run (config settings, auto-selection on part size, etc.).



trunk/kdesupport/akonadi/server/src/storage/parthelper.cpp
<http://reviewboard.kde.org/r/13/#comment6>

    Do we need the "_data" suffix at all?



trunk/kdesupport/akonadi/server/src/storage/parthelper.cpp
<http://reviewboard.kde.org/r/13/#comment7>

    Seeing this code repeated a few times, we probably want a helper method fileNameForPart() or something like that?



trunk/kdesupport/akonadi/server/src/storage/parthelper.cpp
<http://reviewboard.kde.org/r/13/#comment8>

    This assumes that value is the id, which is not always true. One place where this method might be used is removing an item and all its parts. In this case column would be "pimItemId" and value the item id.



trunk/kdesupport/akonadi/server/src/storage/parthelper.cpp
<http://reviewboard.kde.org/r/13/#comment9>

    Maybe call loadData(Part&) here instead?


- Volker


On 2009-02-04 04:27:40, Andras Mantia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/13/
> -----------------------------------------------------------
> 
> (Updated 2009-02-04 04:27:40)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Preliminary implementation of storing the payload data in files instead of the database. It work for me, but it is not well tested. I'd like to get a general feedback about the idea how it is implemented (or anything else, if you have a comment). The basic idea is to use a helper class when dealing with Part objects, and the helper class decides where to store/load the data.
> 
> 
> Diffs
> -----
> 
>   trunk/kdesupport/akonadi/server/CMakeLists.txt 921033 
>   trunk/kdesupport/akonadi/server/src/akonadi.cpp 921033 
>   trunk/kdesupport/akonadi/server/src/akonadiconnection.h 921033 
>   trunk/kdesupport/akonadi/server/src/cachecleaner.cpp 921033 
>   trunk/kdesupport/akonadi/server/src/global.h 921033 
>   trunk/kdesupport/akonadi/server/src/handler/append.cpp 921033 
>   trunk/kdesupport/akonadi/server/src/handler/copy.cpp 921033 
>   trunk/kdesupport/akonadi/server/src/handler/fetch.cpp 921033 
>   trunk/kdesupport/akonadi/server/src/handler/store.cpp 921033 
>   trunk/kdesupport/akonadi/server/src/storage/akonadidb.xml 921033 
>   trunk/kdesupport/akonadi/server/src/storage/datastore.cpp 921033 
>   trunk/kdesupport/akonadi/server/src/storage/entities-header.xsl 921033 
>   trunk/kdesupport/akonadi/server/src/storage/parthelper.h PRE-CREATION 
>   trunk/kdesupport/akonadi/server/src/storage/parthelper.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/13/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andras
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/