[Kde-pim] Review Request: Send payload file name to the client [client side]

[Andras Mantia]

> On 2009-02-12 01:49:45, Volker Krause wrote:
> > I don't think we need the ItemFetchScope changes, as I don't see a use case where an application would prefer file or direct transfer, it's a protocol detail IMHO (and one that only exists for backward compatibility). So, this option should either be entirely omitted (and a new protocol version enforced, see session_p.*) or made dependent on the server protocol version.

Yes, now I looked again and I think we don't need these changes. The new ItemFetchJob could always add the AKONADI_PARAM_EXTERNALPAYLOAD command argument if the protocol version is above a certain number. I have yet to figure out how to detect what protocol does the server support...


- Andras


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/55/#review66
-----------------------------------------------------------


On 2009-02-11 13:23:51, Andras Mantia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/55/
> -----------------------------------------------------------
> 
> (Updated 2009-02-11 13:23:51)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This patch extends the client/server protocol in a way that if the client supports direct loading of the payload data from a file, the filename is sent through the socket, not the whole data, thus limiting the amount of data that needs to be transported. This is the client side of the patch.
> I'd like to get feedback especially on the protocol extension.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/akonadi/item.cpp 924623 
>   trunk/KDE/kdepimlibs/akonadi/itemfetchjob.cpp 924623 
>   trunk/KDE/kdepimlibs/akonadi/itemfetchscope.h 924623 
>   trunk/KDE/kdepimlibs/akonadi/itemfetchscope.cpp 924623 
>   trunk/KDE/kdepimlibs/akonadi/itemfetchscope_p.h 924623 
>   trunk/KDE/kdepimlibs/akonadi/itemserializer.h 924623 
>   trunk/KDE/kdepimlibs/akonadi/itemserializer.cpp 924623 
> 
> Diff: http://reviewboard.kde.org/r/55/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andras
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/