[Kde-pim] Review Request: Akonadi: helper class for common MIME type checks

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/78/#review107
-----------------------------------------------------------

Ship it!


Looks good to me, certainly a task we want helper methods for.

- Volker


On 2009-02-14 10:11:24, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/78/
> -----------------------------------------------------------
> 
> (Updated 2009-02-14 10:11:24)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> MIME types can have aliases and be inherited from a parent MIME type thus checking for string equality will not always give the correct result.
> 
> Correct checking is provided by KMimeType, however instead of requiring that every client implements its own "is this my type of collection" check, this new helper class provides convenience methods for the common check Akonadi clients will face.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepimlibs/akonadi/CMakeLists.txt 926134 
>   /trunk/KDE/kdepimlibs/akonadi/mimetypechecker.h PRE-CREATION 
>   /trunk/KDE/kdepimlibs/akonadi/mimetypechecker.cpp PRE-CREATION 
>   /trunk/KDE/kdepimlibs/akonadi/mimetypechecker_p.h PRE-CREATION 
>   /trunk/KDE/kdepimlibs/akonadi/tests/CMakeLists.txt 926134 
>   /trunk/KDE/kdepimlibs/akonadi/tests/mimetypecheckertest.h PRE-CREATION 
>   /trunk/KDE/kdepimlibs/akonadi/tests/mimetypecheckertest.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/78/diff
> 
> 
> Testing
> -------
> 
> Unit tested. Included in patch
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/