[Kde-pim] Review Request: korganizer: fixing sub resource related user visible error message

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/44/#review49
-----------------------------------------------------------

Ship it!


Looks good to me.

- Volker


On 2009-02-08 09:07:21, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/44/
> -----------------------------------------------------------
> 
> (Updated 2009-02-08 09:07:21)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> When right clicking a sub resource of the Akonadi compatibility resource and then clicking "Edit..." I get a message box with the following text:
> 
> Cannot edit the subresource (I18N_ARGUMENT_MISSING).
> 
> The patch fixes two issues:
> - resource->objectName() is not related to the sub resource at all. Probably a porting mistake
> - i18n functions using KLocalizedString get substitution arguments passed as parameters, i.e. KLocalizedString does the substitution, not the resulting QString
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/korganizer/resourceview.cpp 923346 
> 
> Diff: http://reviewboard.kde.org/r/44/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/