[Kde-pim] Review Request: Improve names display of KRes bridge resources
Volker Krause
vkrause at kde.org
Mon Feb 9 15:13:11 GMT 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/46/#review55
-----------------------------------------------------------
Ship it!
Looks good to me.
- Volker
On 2009-02-08 11:32:54, Kevin Krammer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/46/
> -----------------------------------------------------------
>
> (Updated 2009-02-08 11:32:54)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> Synchronize the agent name with the kres resource name which is also used to name the top level collection.
> Also set EntityDisplayAttribute on retrieveCollections() and check it on collectionChanged().
> Set appropriate icons on these attributes.
>
>
> This addresses bug 177428.
> https://bugs.kde.org/show_bug.cgi?id=177428
>
>
> Diffs
> -----
>
> /trunk/KDE/kdepim/akonadi/resources/kcal/kcalresource.cpp 923448
> /trunk/KDE/kdepim/akonadi/resources/kabc/kabcresource.cpp 923448
>
> Diff: http://reviewboard.kde.org/r/46/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kevin
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list