[Kde-pim] Review Request: korganizer: replacing the application specific assignment visitor with the one from kdepimlibs/kcal

Volker Krause vkrause at kde.org
Fri Feb 13 12:16:57 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/60/#review88
-----------------------------------------------------------

Ship it!


Thanks!

- Volker


On 2009-02-13 03:58:17, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/60/
> -----------------------------------------------------------
> 
> (Updated 2009-02-13 03:58:17)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Calling convention almost identical: first argument is the one assigned to, second one is the source of the data.
> Need to check both pointers before delegation since this seems to be valid but should result in a failed assignment.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/korganizer/incidencechanger.h 925478 
>   /trunk/KDE/kdepim/korganizer/incidencechanger.cpp 925478 
> 
> Diff: http://reviewboard.kde.org/r/60/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list