[Kde-pim] Review Request: Emit calendarLoaded() in CalendarResources:load()

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/65/#review99
-----------------------------------------------------------


Can't comment about the change to KOrganizer (looks OK to me though), but the change to KCal::CalendarResources looks good

The API docs if its base class KCal::Calendar says:

void KCal::Calendar::calendarLoaded   (   )    [signal]
 Signals that the calendar has been loaded into memory. 

- Kevin


On 2009-02-13 15:58:04, Sergio Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/65/
> -----------------------------------------------------------
> 
> (Updated 2009-02-13 15:58:04)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> KOrganizer works very well with resource loading if it's the resource view doing the loading, but doesn't get notified if another component loads the resource.
> 
> If you start kontact on the summary view, and then switch to Calendar, you have to hit refresh to see the incidences (the first time only).
> 
> The problem is that CalendarResources::load() isn't emitting calendarLoaded() like specified in KCal::Calendar API.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/korganizer/actionmanager.cpp 925222 
>   trunk/KDE/kdepimlibs/kcal/calendarresources.cpp 924907 
> 
> Diff: http://reviewboard.kde.org/r/65/diff
> 
> 
> Testing
> -------
> 
> Played around with switching views and resource reloading in kontact.
> 
> 
> Thanks,
> 
> Sergio
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/