[Kde-pim] Review Request: Allow creation of new top level folder in folder selection dialogue

[Jonathan Marten]

> On 2009-02-17 02:29:57, Thomas McGuire wrote:
> > trunk/KDE/kdepim/kmail/folderselectiontreewidget.h, line 166
> > <http://reviewboard.kde.org/r/105/diff/1/?file=700#file700line166>
> >
> >     In KMail, members are prefixed with m, normally, so make it mCreateFolderAction.
> >     Also, there is already a private section above, which Szymon confusingly added to the start of the function.

Original private section moved to the conventional place at the end, and combined with this.


> On 2009-02-17 02:29:57, Thomas McGuire wrote:
> > trunk/KDE/kdepim/kmail/folderselectiontreewidget.cpp, line 126
> > <http://reviewboard.kde.org/r/105/diff/1/?file=701#file701line126>
> >
> >     This change looks wrong to me.
> >     The logic here is: If the item has no folder or if it has a folder and that folder is readonly, disable selection for that item.

The logic here took some working out, but in the original version the "Local Folders" root (fti->folder() being NULL) could not be selected to create a subfolder there.  Now that the dialogue's "OK" button is disabled where it is not applicable via the actionsAllowed() signal, it isn't really necessary to always disable folders that are not allowed in the tree.  So the condition here is now: only if there is a folder and it is explicitly read-only then the tree item is unselectable.

Have updated the comment above to reflect this.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/105/#review145
-----------------------------------------------------------


On 2009-02-16 10:31:03, Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/105/
> -----------------------------------------------------------
> 
> (Updated 2009-02-16 10:31:03)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Fix for the old problem of not being able to create a new subfolder in certain places when using the folder selection tree view - in particular, not being able to create a new top level local folder.
> 
> Also tidied up the operation of this dialogue, centralising the decisions in FolderSelectionTreeWidget instead of having them duplicated in FolderSelectionDialog.  Changed the signal/slot connections between the two.  Use a KAction for the popup menu and enable/disable it as required.
> 
> Disable the "OK" button in the dialogue where it is not allowed.  Previously a folder with "No Content", e.g. the "Local Folders" or an IMAP root, could be selected as a filter or move/copy destination.
> 
> 
> This addresses bug 128796.
>     https://bugs.kde.org/show_bug.cgi?id=128796
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kmail/folderselectiondialog.h 926798 
>   trunk/KDE/kdepim/kmail/folderselectiondialog.cpp 926798 
>   trunk/KDE/kdepim/kmail/folderselectiontreewidget.h 926798 
>   trunk/KDE/kdepim/kmail/folderselectiontreewidget.cpp 926798 
> 
> Diff: http://reviewboard.kde.org/r/105/diff
> 
> 
> Testing
> -------
> 
> Checked operation of all uses of FolderSelectionDialog or FolderRequester for correct enable/disable of "OK" and "New Subfolder" buttons.
> 
> Checked creation of new subfolder where this is allowed.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/