[Kde-pim] Review Request: calendar entries are written with MAILTO attribute even when there is no MAILTO value

[Allen Winter]

> On 2009-02-22 07:54:35, Allen Winter wrote:
> > The changes in icalformat_p.cpp aren't correct according to RFC.  We should not write an ORGANIZER nor an ATTENDEE that has an empty email address.  I'll take it from here.

I have an updated patch ready to commit that does not write ORGANIZER nor ATTENDEE properties if the email is empty.  However, I'm blocked testing it at the moment.  just providing an update.


- Allen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/148/#review232
-----------------------------------------------------------


On 2009-02-21 21:50:35, Sergio Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/148/
> -----------------------------------------------------------
> 
> (Updated 2009-02-21 21:50:35)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> I'm posting a patch on behalf of Roland Waters who posted it on b.k.o on behalf of Marco Nelles.
> 
> From bug #184807:
> """
> Currently when calendar data are written, the MAILTO property is stored even
> when there is no value given for the MAILTO URI. This results in calendar data
> lines like:
> ORGANIZER;CN=Test User:MAILTO:
> This, however, is not a valid URI. Therefore  several parsers throw a parse
> error at this property - the best example is the Funambol/Groupdav parser.
> 
> Th fix would be to check if the property has a value and only write it when a
> value is given.
> """
> 
> I modified the patch so it applies against KDE4 and changes adapted it's coding style.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=184807.
>     https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=184807
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp 929777 
>   trunk/KDE/kdepimlibs/kcal/vcalformat.cpp 929777 
> 
> Diff: http://reviewboard.kde.org/r/148/diff
> 
> 
> Testing
> -------
> 
> I tried using the ics validator (http://severinghaus.org/projects/icv/) before and after the patch.
> 
> before:
> -------
> Sorry, your calendar could not be parsed.
> Error: 	Error was: Error at line 199: Expected scheme-specific part at index 7: MAILTO:
> Cause: 	Caused by: Expected scheme-specific part at index 7: MAILTO:
> 
> after:
> ------
> Success
> 
> 
> Thanks,
> 
> Sergio
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/