[Kde-pim] Review Request: Use IncidenceBase::updated() to notify any observers

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/102/
-----------------------------------------------------------

(Updated 2009-02-16 04:06:43.241499)


Review request for KDE PIM.


Changes
-------

Removed the explicit Calendar::setModified( true ) in the ICal part of the patch.
Works for me


Summary
-------

When updating an incendence through assignment, the instance itself gets updated, but other parts of the infrastructure might still consider it unchanged.

For example the KCal resource does not actually save its internal calendar, because it is not marked as modified. IncidenceBase::updated() notifies the calender which is installed as an observer.

The patch for the ICal resource is not strictly needed since it called mCalendar->setModified( true ) explicitly, but I think this call could actually be removed if the modification is applied.


Diffs (updated)
-----

  /trunk/KDE/kdepim/akonadi/resources/ical/icalresource.cpp 926589 
  /trunk/KDE/kdepim/akonadi/resources/kcal/kcalresource.cpp 926809 

Diff: http://reviewboard.kde.org/r/102/diff


Testing
-------


Thanks,

Kevin

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/