[Kde-pim] Review Request: Warn if a mail is sent to too many recipients

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/133/#review194
-----------------------------------------------------------


not tested, but the code looks nice.  I have only minor nits.


branches/kdepim/enterprise/kdepim/kmail/configuredialog.cpp
<http://reviewboard.kde.org/r/133/#comment99>

    I wonder if a max of 255 is enough? 



branches/kdepim/enterprise/kdepim/kmail/kmail.kcfg
<http://reviewboard.kde.org/r/133/#comment100>

    please add a <tooltip> and a <whatsthis>



branches/kdepim/enterprise/kdepim/kmail/kmail.kcfg
<http://reviewboard.kde.org/r/133/#comment101>

    please add a <tooltip> and a <whatsthis>



branches/kdepim/enterprise/kdepim/kmail/kmail.kcfg
<http://reviewboard.kde.org/r/133/#comment102>

    again, I wonder if 255 is large enough.  I really don't know. couldn't hurt to make it much larger. I guess



branches/kdepim/enterprise/kdepim/kmail/kmcomposewin.h
<http://reviewboard.kde.org/r/133/#comment103>

    check spelling :)



branches/kdepim/enterprise/kdepim/kmail/kmcomposewin.cpp
<http://reviewboard.kde.org/r/133/#comment104>

    thomas will yell at you about coding style.  in kdepim, we put the opening brace on the same lin e with the 'if'.


- Allen


On 2009-02-20 04:57:56, Andras Mantia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/133/
> -----------------------------------------------------------
> 
> (Updated 2009-02-20 04:57:56)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Implement https://www.intevation.de/roundup/kolab/issue3377 , add a warning if there are too many recipients. The warning can be turned off and the threshold number is user configurable.
> 
> 
> Diffs
> -----
> 
>   branches/kdepim/enterprise/kdepim/kmail/configuredialog.cpp 928827 
>   branches/kdepim/enterprise/kdepim/kmail/configuredialog_p.h 928827 
>   branches/kdepim/enterprise/kdepim/kmail/kmail.kcfg 928827 
>   branches/kdepim/enterprise/kdepim/kmail/kmcomposewin.h 928827 
>   branches/kdepim/enterprise/kdepim/kmail/kmcomposewin.cpp 928827 
> 
> Diff: http://reviewboard.kde.org/r/133/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andras
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/