[Kde-pim] Review Request: Remove duplicated code in KOAgendaView::changeIncidenceDisplayAdded()

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/38/#review52
-----------------------------------------------------------



trunk/KDE/kdepim/korganizer/views/agendaview/koagendaview.cpp
<http://reviewboard.kde.org/r/38/#comment35>

    since this was an if-then-else construct before, have you checked it wasn't there to have updateEventIndicators() between removeIncidence() and changeIncidenceDisplayAdded() and not after the latter?


- Kevin


On 2009-02-08 11:08:40, Sergio Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/38/
> -----------------------------------------------------------
> 
> (Updated 2009-02-08 11:08:40)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This patch makes KOAgendaView::changeIncidenceDisplayAdded() share code with KOAgendaView::fillAgenda().
> 
> changeIncidenceDisplayAdded() has some bugs displaying multi-day recurrent events and multi day events whose start isn't visible, these bugs 
> were all fixed in fillAgenda recently.
> 
> Both these functions have the same goal, the difference is that changeIncidenceDisplayAdded only shows one incidence, fillAgenda shows them all, so I created a new private function, displayIncidence(), which is shared by both functions and implements all the recurrence/multi-day logic.
> 
> 
> This addresses bugs 99634 and 108443.
>     https://bugs.kde.org/show_bug.cgi?id=99634
>     https://bugs.kde.org/show_bug.cgi?id=108443
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/korganizer/views/agendaview/koagendaview.h 923377 
>   trunk/KDE/kdepim/korganizer/views/agendaview/koagendaview.cpp 923377 
> 
> Diff: http://reviewboard.kde.org/r/38/diff
> 
> 
> Testing
> -------
> 
> Tested with recurring events, recurring multi-day events, normal events, all day events, some of them without a visible start.
> 
> 
> Thanks,
> 
> Sergio
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/