[Kde-pim] Review Request: Using Akonadi::MimeTypeChecker to check Collection and Item MIME types

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/88/#review113
-----------------------------------------------------------

Ship it!


Looks good.

- Volker


On 2009-02-15 05:04:06, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/88/
> -----------------------------------------------------------
> 
> (Updated 2009-02-15 05:04:06)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Instead of comparing the MIME type strings which can fail due to MIME types having aliases, etc. use the newly introduced helper class Akonadi::MimeTypeChecker which additionally checks aliases and MIME inheritance using kdelibs KMimeType facilities.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/akonadi/agents/nepomuk_contact_feeder/nepomukcontactfeeder.cpp 926418 
>   /trunk/KDE/kdepim/akonadi/opensync/akonadi_opensync.cpp 926418 
>   /trunk/KDE/kdepim/akonadi/resources/birthdays/birthdaysresource.cpp 926418 
>   /trunk/KDE/kdepim/akonadi/resources/kabc/kabcresource.h 926418 
>   /trunk/KDE/kdepim/akonadi/resources/kabc/kabcresource.cpp 926418 
>   /trunk/KDE/kdepim/kcontactmanager/mainwidget.cpp 926418 
>   /trunk/KDE/kdepim/kresources/akonadi/kabc/resourceakonadi.cpp 926418 
>   /trunk/KDE/kdepim/kresources/akonadi/kcal/resourceakonadi.cpp 926418 
> 
> Diff: http://reviewboard.kde.org/r/88/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/