[Kde-pim] Review Request: Send payload file name to the client [client side]

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/55/#review149
-----------------------------------------------------------

Ship it!


Looks like the changes in itemfetchscope_p.h are not needed either. Looks good apart from that.

- Volker


On 2009-02-17 04:25:15, Andras Mantia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/55/
> -----------------------------------------------------------
> 
> (Updated 2009-02-17 04:25:15)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This patch extends the client/server protocol in a way that if the client supports direct loading of the payload data from a file, the filename is sent through the socket, not the whole data, thus limiting the amount of data that needs to be transported. This is the client side of the patch.
> I'd like to get feedback especially on the protocol extension.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/akonadi/item.cpp 927087 
>   trunk/KDE/kdepimlibs/akonadi/itemfetchjob.cpp 927087 
>   trunk/KDE/kdepimlibs/akonadi/itemfetchscope_p.h 927087 
>   trunk/KDE/kdepimlibs/akonadi/itemserializer.h 927087 
>   trunk/KDE/kdepimlibs/akonadi/itemserializer.cpp 927087 
>   trunk/KDE/kdepimlibs/akonadi/session_p.h 927087 
> 
> Diff: http://reviewboard.kde.org/r/55/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andras
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/