[Kde-pim] Review Request: Completing recurring to-do doesn't create new to-do

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/197/#review291
-----------------------------------------------------------


Maybe add a little unit test for this?

- Thomas


On 2009-02-26 16:18:40, Sergio Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/197/
> -----------------------------------------------------------
> 
> (Updated 2009-02-26 16:18:40)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Here's a patch Pete at bug #170660 made.
> 
> When you have a recurring to-do and mark it completed the due date is supposed to move to the next occurrence ( and the to-do remains uncompleted).
> 
> This behaviour is currently broken, the due date doesn't change and the to-do gets completed.
> 
> The reason it's broken it because there's a comparison with an invalid date, a recurrence with no end date will have an invalid end date, so nextDate > endDateTime will always return true.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=170660.
>     https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=170660
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/kcal/todo.cpp 932602 
> 
> Diff: http://reviewboard.kde.org/r/197/diff
> 
> 
> Testing
> -------
> 
> Made a recurring to-do, with due date before today, and marking it as completed works as expected.
> 
> 
> Thanks,
> 
> Sergio
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/